Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for join operations with low build table cardinality #18105

Draft
wants to merge 2 commits into
base: branch-25.04
Choose a base branch
from

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Feb 26, 2025

Description

Investigates performance hotspots in #16025
This PR adds inner-, left-, and full-join benchmarks that sweep on the number of distinct keys in the build table.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link

copy-pr-bot bot commented Feb 26, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Feb 26, 2025
@shrshi
Copy link
Contributor Author

shrshi commented Feb 28, 2025

lchm_join_benchmark

@shrshi shrshi added feature request New feature or request non-breaking Non-breaking change labels Feb 28, 2025
@shrshi
Copy link
Contributor Author

shrshi commented Feb 28, 2025

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Feb 28, 2025

/ok to test

@PointKernel
Copy link
Member

lchm_join_benchmark

To better highlight performance degradation in low cardinality cases, we should consider switching the y-axis from runtime to throughput as shown in the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants